Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Outdated celo dependencies #7551

Open
aaronmgdr opened this issue Aug 8, 2024 · 2 comments · May be fixed by #7622
Open

[Bug]: Outdated celo dependencies #7551

aaronmgdr opened this issue Aug 8, 2024 · 2 comments · May be fixed by #7622
Labels
bug Something isn't working libraries Impacts the Libraries triage In need of triage

Comments

@aaronmgdr
Copy link

aaronmgdr commented Aug 8, 2024

Impacted Library name

ledger live common

Impacted Library version

latest

Describe the bug

The short message is that ledger-live uses an old version of @celo/contractkit and needs to move away from that version to continue working.

Why?

Some history: When celo launched as an alt L1 it used a custom transaction type that like eth legacy was a type 0 but with extra parameters. we call this celo-legacy type. While the celo chain now supports eth-legacy, type 2 and celo’s specific cip64 (gas token) transactions, @celo/contractkit@3.0 only supports celo-legacy transactions.

But celo-legacy transactions are deprecated and the next hardfork will completely remove support for them. Furthermore because the chain will remove support, the latest celo-ledger-spender app only supports cip64 and eip1559 transactions making it already incompatible with ledger live. An unfortunate situation we were not aware of until recently.

When is the hardfork?

Uncertain for celo mainnet (2 months) but the alfajores testnet is moving to L2 status by end of September.

Wait What is the Hardfork?

I say hardfork but is bigger than that as CELO is becoming an OP based Layer 2.This is why the transaction type is being removed. It is not being backported to the new stack.

"@celo/connect": "^3.0.1",
"@celo/contractkit": "^3.0.1",
"@celo/utils": "^3.0.1",
"@celo/wallet-base": "^3.0.1",
"@celo/wallet-ledger": "^3.0.1",

Expected behavior

upgrade to latest versions. eg 8.1.0 for celo/contractkit

@aaronmgdr aaronmgdr added bug Something isn't working libraries Impacts the Libraries triage In need of triage labels Aug 8, 2024
aaronmgdr added a commit to aaronmgdr/ledger-live that referenced this issue Aug 19, 2024
@aaronmgdr aaronmgdr linked a pull request Aug 19, 2024 that will close this issue
3 tasks
aaronmgdr added a commit to aaronmgdr/ledger-live that referenced this issue Aug 22, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label, comment, or consider closing it.

@github-actions github-actions bot added the Stale label Sep 13, 2024
@aaronmgdr
Copy link
Author

this bot is hilarious

@github-actions github-actions bot removed the Stale label Sep 14, 2024
aaronmgdr added a commit to aaronmgdr/ledger-live that referenced this issue Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libraries Impacts the Libraries triage In need of triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant