test: 🎨 Improve receive E2E test

LedgerHQ · Nov 27, 2024 · faef7ed · faef7ed
1 parent eb4a19b
commit faef7ed
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 6 deletions.
diff --git a/.changeset/rotten-horses-shop.md b/.changeset/rotten-horses-shop.md
@@ -0,0 +1,6 @@
+---
+"ledger-live-desktop": minor
+"@ledgerhq/live-common": minor
+---
+
+Fix Speculos CI + Update checks on receive and subAccount tests"
diff --git a/apps/ledger-live-desktop/tests/page/modal/receive.modal.ts b/apps/ledger-live-desktop/tests/page/modal/receive.modal.ts
@@ -34,6 +34,12 @@ export class ReceiveModal extends Modal {
     await this.skipDeviceButton.click();
   }
 
+  @step("Retrieve fees amount value")
+  async getAddressDisplayed() {
+    const text = await this.addressDisplayedValue.textContent();
+    return text ? text?.split(" ")[0] : "";
+  }
+
   @step("Verify receive address correctness $0")
   async expectValidReceiveAddress(address: string) {
     await expect(this.verifyAddressOnDeviceLabel).toBeVisible();

diff --git a/apps/ledger-live-desktop/tests/page/speculos.page.ts b/apps/ledger-live-desktop/tests/page/speculos.page.ts
@@ -28,7 +28,7 @@ import { delegateCosmos, sendCosmos } from "tests/families/cosmos";
 import { delegateSolana, sendSolana } from "tests/families/solana";
 export class SpeculosPage extends AppPage {
   @step("Verify receive address correctness on device")
-  async expectValidAddressDevice(account: Account) {
+  async expectValidAddressDevice(account: Account, addressDisplayed: string) {
     let deviceLabels: string[];
 
     switch (account.currency) {
@@ -46,7 +46,7 @@ export class SpeculosPage extends AppPage {
 
     await waitFor(deviceLabels[0]);
     const events = await pressUntilTextFound(deviceLabels[1]);
-    const isAddressCorrect = containsSubstringInEvent(account.address, events);
+    const isAddressCorrect = containsSubstringInEvent(addressDisplayed, events);
     expect(isAddressCorrect).toBeTruthy();
     await pressBoth();
   }

diff --git a/apps/ledger-live-desktop/tests/specs/speculos/receive.address.spec.ts b/apps/ledger-live-desktop/tests/specs/speculos/receive.address.spec.ts
@@ -66,9 +66,10 @@ for (const account of accounts) {
             break;
         }
         await app.modal.continue();
-        await app.receive.expectValidReceiveAddress(account.account.address);
+        const displayedAddress = await app.receive.getAddressDisplayed();
+        await app.receive.expectValidReceiveAddress(displayedAddress);
 
-        await app.speculos.expectValidAddressDevice(account.account);
+        await app.speculos.expectValidAddressDevice(account.account, displayedAddress);
         await app.receive.expectApproveLabel();
       },
     );

diff --git a/apps/ledger-live-desktop/tests/specs/speculos/subAccount.spec.ts b/apps/ledger-live-desktop/tests/specs/speculos/subAccount.spec.ts
@@ -84,9 +84,11 @@ for (const token of subAccountReceive) {
         await app.receive.selectToken(token.account);
 
         await app.modal.continue();
-        await app.receive.expectValidReceiveAddress(token.account.address);
 
-        await app.speculos.expectValidAddressDevice(token.account);
+        const displayedAddress = await app.receive.getAddressDisplayed();
+        await app.receive.expectValidReceiveAddress(displayedAddress);
+
+        await app.speculos.expectValidAddressDevice(token.account, displayedAddress);
         await app.receive.expectApproveLabel();
       },
     );