Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display all address in the ckb2021 format #31

Merged
merged 18 commits into from
Aug 8, 2024
Merged

feat: display all address in the ckb2021 format #31

merged 18 commits into from
Aug 8, 2024

Conversation

homura
Copy link

@homura homura commented Jul 12, 2024 •
edited
Loading

This PR

  • modifies the app to display all addresses in the CKB2021 format
  • refactors the code to migrate the deprecated cx API to the latest

This was referenced Jul 12, 2024
Closed
Open
@homura homura mentioned this pull request Jul 20, 2024
Closed
@cedelavergne-ledger
Copy link

Could be interesting/better to use CX_CHECK and CX_ASSERT instead of CX_THROW, allowing a better retrun codes management...

@Keith-CY
Copy link

Keith-CY commented Aug 8, 2024

Could be interesting/better to use CX_CHECK and CX_ASSERT instead of CX_THROW, allowing a better retrun codes management...

Hi @cedelavergne-ledger
Code has been updated, please have a review

@cedelavergne-ledger
Copy link

Could be interesting/better to use CX_CHECK and CX_ASSERT instead of CX_THROW, allowing a better retrun codes management...

Hi @cedelavergne-ledger Code has been updated, please have a review

🤔
Code has not changed recently, and I can still see the CX_THROW... Do I miss something, or do you forget to push your modifications?

@cedelavergne-ledger cedelavergne-ledger merged commit 9922a20 into LedgerHQ:develop Aug 8, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedelavergne-ledger cedelavergne-ledger cedelavergne-ledger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@homura @cedelavergne-ledger @Keith-CY