Merge pull request #718 from LedgerHQ/fix-finalize-return-code-handling

eth,plugin: improve plugin finalize error checks
LedgerHQ · Jan 31, 2025 · 5d94009 · 5d94009
2 parents 24e714b + eb07fa3
commit 5d94009
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src_features/signTx/logic_signTx.c b/src_features/signTx/logic_signTx.c
@@ -435,7 +435,8 @@ __attribute__((noinline)) static uint16_t finalize_parsing_helper(const txContex
 
         pluginFinalize.address = msg_sender;
 
-        if (!eth_plugin_call(ETH_PLUGIN_FINALIZE, (void *) &pluginFinalize)) {
+        if (eth_plugin_call(ETH_PLUGIN_FINALIZE, (void *) &pluginFinalize) <
+            ETH_PLUGIN_RESULT_SUCCESSFUL) {
             PRINTF("Plugin finalize call failed\n");
             report_finalize_error();
             return APDU_NO_RESPONSE;