Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractOneSEVPA: fixed issue in getOutgoingEdges(..) #39

Merged
merged 3 commits into from
Mar 10, 2020
Merged

AbstractOneSEVPA: fixed issue in getOutgoingEdges(..) #39

merged 3 commits into from
Mar 10, 2020

Conversation

DonatoClun
Copy link
Contributor

getOutgoingEdges was returning the wrong transitions when called on a OneSEVPA.
Instead of finding the return transitions from the specified location, it was finding the return transitions from the (variable) location used to generate every possible element of the stack alphabet.

@mtf90 mtf90 merged commit 5c8228a into LearnLib:develop Mar 10, 2020
@mtf90
Copy link
Member

mtf90 commented Mar 10, 2020

Thanks for the pull request and good catch!

If you need this fix sooner rather than later, I suggest you write your own little graph wrapper for an AbstractOneSEVPA with your changes so you can still use the latest stable release.

Since this issue is quite workaround-able, I'm in favor of queuing this with one of the next regular releases.

Conturing pushed a commit to Conturing/automatalib that referenced this pull request Jul 23, 2020
* AbstractOneSEVPA: fixed issue in getOutgoingEdges(..)

* add test case

* add changelog

Co-authored-by: Markus Frohme <markus.frohme@udo.edu>
Conturing pushed a commit to Conturing/automatalib that referenced this pull request Jul 23, 2020
* AbstractOneSEVPA: fixed issue in getOutgoingEdges(..)

* add test case

* add changelog

Co-authored-by: Markus Frohme <markus.frohme@udo.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants