Run CI on Github actions #7654
Merged
Run CI on Github actions #7654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
approved these changes
Sep 6, 2021
|
Not sure why it doesn't run now — maybe because it's a third party PR, but let's merge and see what happens. |
|
Running great — took just 49s for the uncached job! https://github.com/Leaflet/Leaflet/runs/3525418592 |
|
@mourner Nice, that is a lot faster than I expected! |
|
It looks like the tests only ran on PhantomJS though, I guess that is not entirely correct considering the browser parameters passed in. This might be related to my changes to the scripts in the package. I'll open up a separate PR to debug this, hopefully that will just run the task now that an initial version was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #7653 as a
package-lock.jsonfile is needed to runnpm ci. Allows running the CI on Github actions instead of Travis, as it looks like the Travis builds are not running. Added benefit is that forks can use the same configuration to run CI without having to set up Travis and change the source.