Tooltip: stop relying on Browser touch property

[johnd0e]

Rationale: #6978

[johnd0e]

Leaflet/src/layer/Tooltip.js

Lines 106 to 115 in 0f904a5

	getEvents: function () {
	var events = DivOverlay.prototype.getEvents.call(this);
	if (Browser.touch && !this.options.permanent) {
	events.preclick = this._close;
	}
	return events;
	},

Leaflet/src/layer/Tooltip.js

Lines 304 to 320 in 0f904a5

	var onOff = remove ? 'off' : 'on',
	events = {
	remove: this.closeTooltip,
	move: this._moveTooltip
	};
	if (!this._tooltip.options.permanent) {
	events.mouseover = this._openTooltip;
	events.mouseout = this.closeTooltip;
	if (this._tooltip.options.sticky) {
	events.mousemove = this._moveTooltip;
	}
	if (Browser.touch) {
	events.click = this._openTooltip;
	}
	} else {
	events.add = this._openTooltip;
	}

In fact for modern browsers we could avoid handling clicks, and rely just on compatibility mouseover/mouseout even for touch.

[johnd0e]

Going beyond subject: I'd prefer tooltips to behave in slightly different way: if opened on click - do not close on mouseout.

Reason: while such behavior is quite similar to current - it is more flexible, as it would also allow to keep tooltip opened, for convenience.

In this way we could use non-permanent tooltips with some interactive content (e.g. html link).

[Falke-Design]

Do you think Browser.touch was used here because of performance or because of a other reason?

Currently in most places of code touch property check is used to prevent attaching excessive listeners if touch is unsupported.
May be that makes sense for legacy devices (though I doubt that it has any impact on performance with modern ones).

Originally posted by @johnd0e in #6978 (comment)

[johnd0e]

Do you think Browser.touch was used here because of performance or because of a other reason?

I think that mentioned code was written with some assumptions in mind, which used to be true in that times.
But things are changing.

No, I do not think that it's about performance here.
It's rather about clear code logic - "if we use touch device than we need additional handling".
It's convenient logic but nowadays we are unable to say for true if touch device be used or not.

[Falke-Design]

I didn't tested it but looks good

[Falke-Design]

@mourner your part to approve and merge 😉