Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Icons in toolbar - macOS/Chrome #629

Closed
Twista opened this issue Nov 9, 2016 · 5 comments
Closed

Broken Icons in toolbar - macOS/Chrome #629

Twista opened this issue Nov 9, 2016 · 5 comments

Comments

@Twista
Copy link

Twista commented Nov 9, 2016

Hello, first - thanks for awesome work!

There is little bug i found.

How to reproduce

  • Leaflet version I'm using: 1.0.1
  • Leaflet Draw version I'm using: ^0.4.0 or master (be0ca82)
  • Browser (with version) I'm using: Chrome
  • OS/Platform (with version) I'm using: macOS El Capitan

The easiest way how to reproduce is clone current master and open example from docs

$ git clone https://github.com/Leaflet/Leaflet.draw.git
$ open Leaflet.draw/docs/examples/full.html

Then use zoom tool in browser - first icon in every bar has broken icons

What behaviour I'm expecting and which behaviour I'm seeing

leaflet_draw_vector_editing_handlers

Expecting behaviour is that icons are not broken.

Notes

Tried on multiple computers with macOS - The problem seems to be only in Chrome (FF and Safari are ok).

Find out the problem is in CSS (leaflet.draw.css:25) and only if browser uses images/spritesheet.svg . When i changed styles to use images/spritesheet.png - problem disappeared

I would love to send pull-request, but i'm missing experience working with SVG

Thanks!

edit: formating

@ddproxy
Copy link
Member

ddproxy commented Nov 9, 2016

Thanks! I'll include this in the patch later tonight.

@Twista
Copy link
Author

Twista commented Nov 9, 2016

Awesome, thank you!

ddproxy added a commit to ddproxy/Leaflet that referenced this issue Nov 10, 2016
Issue Leaflet#2012 covers mobile devices

Leaflet/Leaflet.draw#629 detected an issue with svg in .leaflet-bar for retina or 'zoomed in' on chrome that would ignore scaling when using negative background positions.
@ddproxy
Copy link
Member

ddproxy commented Nov 10, 2016

@Twista - identified the issue as a chrome bug.

Patch goes out tonight to fix this for Leaflet.Draw, PR Leaflet/Leaflet#5085 on Leaflet for fixing this within Leaflet.

An issue has been reported to Chrome linking to this ticket as well as how to reproduce.

@ddproxy
Copy link
Member

ddproxy commented Nov 10, 2016

@Twista Please close once you have confirmed the issue is resolved, 0.4.3 has been released.

@Twista
Copy link
Author

Twista commented Nov 10, 2016

Just tried and works perfectly. Awesome - Thank you for very quick fix!

@Twista Twista closed this as completed Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants