fix missing sitelinks in item.write() #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeMyst
force-pushed
the
fix-missing-sitelinks
branch
from
b9c5ae9
to
c1daacd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version had a little bug, leading to sitelinks not being written, and in fact being lost in the write() process. Also shortly described in Issue #763
This PR should fix it.
I added an exception for the case that sitelinks are not unique, which could be more verbose - however seemed to somewhat fit into how exceptions are handled at the moment. Please let me know if anything is needed so we can merge!
Cheers