ci: split tests and coverage #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@supernovahs would it be possible to allow PRs to be merged without the "Generate Coverage" check passing? That way external contributors can skip it (since it uses secrets they don't have access to). |
MegaRedHand
force-pushed
the
skip-fireblocks-tests
branch
from
696cb59 to
cc167d4
Compare
checking if there's a setting like this in github |
|
I think leaving that job out of the "Required" list of jobs is enough. |
supernovahs
approved these changes
Feb 5, 2025
MegaRedHand
added a commit
that referenced
this pull request
Feb 5, 2025
Fixes # ### What Changed? Fireblocks tests don't work for external contributors. This PR splits the test run in the CI into two: "Run Tests" and "Generate Coverage". The idea is to have the first one run without fireblocks, while the second one runs with it and is not required for merge. ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
What Changed?
Fireblocks tests don't work for external contributors. This PR splits the test run in the CI into two: "Run Tests" and "Generate Coverage". The idea is to have the first one run without fireblocks, while the second one runs with it and is not required for merge.
Reviewer Checklist
changelog-Xlabels (if applies)