Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bindings for ECDSAStakeRegistry and ECDSAServiceManagerBase #269

Merged
merged 9 commits into from
Feb 4, 2025

Conversation

supernovahs
Copy link
Collaborator

@supernovahs supernovahs commented Feb 4, 2025

Fixes #264

What Changed?

Add ECDSA bindings

Reviewer Checklist

  • New features are tested and documented
  • PR updates the changelog with a description of changes
  • PR has one of the changelog-X labels (if applies)
  • Code deprecates any old functionality before removing it

@supernovahs
Copy link
Collaborator Author

supernovahs commented Feb 4, 2025

ohh , i deleted the extra bindings in local , but its still showing here lol
vs code issue
ahh looks like its showing this line change due to fmt

Copy link
Collaborator Author

@supernovahs supernovahs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

MegaRedHand
MegaRedHand previously approved these changes Feb 4, 2025
Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MegaRedHand MegaRedHand changed the title add ecdsa bindings feat: add bindings for ECDSAStakeRegistry and ECDSAServiceManagerBase Feb 4, 2025
@MegaRedHand MegaRedHand enabled auto-merge (squash) February 4, 2025 18:12
@MegaRedHand MegaRedHand added the changelog-added [changelog] PR adds a new feature label Feb 4, 2025
@MegaRedHand MegaRedHand merged commit a904f5f into main Feb 4, 2025
8 checks passed
@MegaRedHand MegaRedHand deleted the nova/add_ecdsa_bindings branch February 4, 2025 18:27
MegaRedHand added a commit that referenced this pull request Feb 4, 2025
…ase` (#269)

Fixes #264 

### What Changed?
Add ECDSA bindings
### Reviewer Checklist

- [ ] New features are tested and documented
- [ ] PR updates the changelog with a description of changes
- [ ] PR has one of the `changelog-X` labels (if applies)
- [ ] Code deprecates any old functionality before removing it

---------

Co-authored-by: harshit singhal <nova@harshits-MacBook-Pro.local>
Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Feb 4, 2025
MegaRedHand added a commit that referenced this pull request Feb 4, 2025
…ase` (#269)

Fixes #264 

### What Changed?
Add ECDSA bindings
### Reviewer Checklist

- [ ] New features are tested and documented
- [ ] PR updates the changelog with a description of changes
- [ ] PR has one of the `changelog-X` labels (if applies)
- [ ] Code deprecates any old functionality before removing it

---------

Co-authored-by: harshit singhal <nova@harshits-MacBook-Pro.local>
Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-added [changelog] PR adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add back ECDSA bindings in main branch
3 participants