-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add bindings for ECDSAStakeRegistry
and ECDSAServiceManagerBase
#269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohh , i deleted the extra bindings in local , but its still showing here lol |
MegaRedHand
reviewed
Feb 4, 2025
supernovahs
commented
Feb 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^
MegaRedHand
previously approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ECDSAStakeRegistry
and ECDSAServiceManagerBase
MegaRedHand
reviewed
Feb 4, 2025
MegaRedHand
approved these changes
Feb 4, 2025
pablodeymo
approved these changes
Feb 4, 2025
MegaRedHand
added a commit
that referenced
this pull request
Feb 4, 2025
…ase` (#269) Fixes #264 ### What Changed? Add ECDSA bindings ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: harshit singhal <nova@harshits-MacBook-Pro.local> Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
Closed
MegaRedHand
added a commit
that referenced
this pull request
Feb 4, 2025
…ase` (#269) Fixes #264 ### What Changed? Add ECDSA bindings ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: harshit singhal <nova@harshits-MacBook-Pro.local> Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #264
What Changed?
Add ECDSA bindings
Reviewer Checklist
changelog-X
labels (if applies)