Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove homepage from testing-utils #266

Merged
merged 4 commits into from
Feb 4, 2025

Conversation

supernovahs
Copy link
Collaborator

Fixes #

What Changed?

Removes hompage from testing utils. This used to throw error when deploying on crates io which i used to remove manually

Reviewer Checklist

  • New features are tested and documented
  • PR updates the changelog with a description of changes
  • PR has one of the changelog-X labels (if applies)
  • Code deprecates any old functionality before removing it

@supernovahs supernovahs added the changelog-fixed [changelog] PR fixes a bug label Feb 2, 2025
@supernovahs supernovahs changed the title remove hompage remove homepage from testing-utils Feb 2, 2025
Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@supernovahs supernovahs merged commit ce4749b into main Feb 4, 2025
8 checks passed
@supernovahs supernovahs deleted the nova/remove_homepage_from_testing_utils branch February 4, 2025 21:55
@github-actions github-actions bot mentioned this pull request Feb 4, 2025
MegaRedHand pushed a commit that referenced this pull request Feb 5, 2025
Fixes #

### What Changed?
Removes hompage from testing utils. This used to throw error when
deploying on crates io which i used to remove manually
### Reviewer Checklist

- [ ] New features are tested and documented
- [ ] PR updates the changelog with a description of changes
- [ ] PR has one of the `changelog-X` labels (if applies)
- [ ] Code deprecates any old functionality before removing it

---------

Co-authored-by: supernovahs <supernovahs@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-fixed [changelog] PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants