fix: use rewards coordinator in get split functions #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
requested changes
Jan 30, 2025
MegaRedHand
added
changelog-breaking
Now is set it as zero, since is no going to be needed in avsregistry writer operations
Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
auto-merge was automatically disabled
February 5, 2025 12:43
Head branch was pushed to by a user without write access
MegaRedHand
added a commit
that referenced
this pull request
Feb 5, 2025
### What Changed? In get_operator_avs_split and get_operator_pi_split was being used delegation manager address to instantiate rewards coordinator. Now is used rewards coordinator's address. ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it --------- Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
supernovahs
added a commit
that referenced
this pull request
Feb 6, 2025
Release 0.2.0 ### What Changed? TODO: Merge #250 ### Reviewer Checklist - [ ] New features are tested and documented - [ ] PR updates the changelog with a description of changes - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
In get_operator_avs_split and get_operator_pi_split was being used delegation manager address to instantiate rewards coordinator. Now is used rewards coordinator's address.
Reviewer Checklist
changelog-Xlabels (if applies)