Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test_register_and_update_operator #223

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Conversation

ricomateo
Copy link
Contributor

@ricomateo ricomateo commented Jan 16, 2025

Motivation
The test_register_and_update_operator test fails since it tries to register an operator that is already registered.
This error was not caught before because it was using a wrong DelegationManager address and it was failing silently.

Description
This PR adds a new function new_test_writer_with_private_key that allows to create a test ELChainWriter with a specific account.
To fix the test, we simply use an unregistered account.

@ricomateo ricomateo marked this pull request as ready for review January 16, 2025 18:51
Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricomateo ricomateo merged commit 7895be8 into main Jan 16, 2025
3 checks passed
@ricomateo ricomateo deleted the fix-failing-test branch January 16, 2025 18:56
@MegaRedHand MegaRedHand changed the title test: fix test_register_and_update_operator test: fix test_register_and_update_operator Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants