Add compliance tests (#339)

Co-authored-by: tomasarrachea <tomas.arrachea@lambdaclass.com>
Layr-Labs · Oct 2, 2024 · 91ca9d4 · 91ca9d4
1 parent 0b642fa
commit 91ca9d4
Show file tree

Hide file tree

Showing 3 changed files with 45 additions and 14 deletions.
diff --git a/cmd/egnaddrs/main_test.go b/cmd/egnaddrs/main_test.go
@@ -26,14 +26,16 @@ func TestEgnAddrsWithServiceManagerFlag(t *testing.T) {
 	// read input from JSON if available, otherwise use default values
 	var defaultInput = struct {
 		ServiceManagerAddress common.Address `json:"service_manager_address"`
+		RpcUrl                string         `json:"rpc_url"`
 	}{
 		ServiceManagerAddress: testutils.GetContractAddressesFromContractRegistry(anvilEndpoint).ServiceManager,
+		RpcUrl:                anvilEndpoint,
 	}
 	testData := testutils.NewTestData(defaultInput)
 
 	args := []string{"egnaddrs"}
 	args = append(args, "--service-manager", testData.Input.ServiceManagerAddress.Hex())
-	args = append(args, "--rpc-url", anvilEndpoint)
+	args = append(args, "--rpc-url", testData.Input.RpcUrl)
 	// we just make sure it doesn't crash
 	run(args)
 }

diff --git a/services/avsregistry/avsregistry_chaincaller_test.go b/services/avsregistry/avsregistry_chaincaller_test.go
@@ -2,6 +2,7 @@ package avsregistry
 
 import (
 	"context"
+	"encoding/hex"
 	"errors"
 
 	"math/big"
@@ -33,11 +34,24 @@ func (f *fakeOperatorInfoService) GetOperatorInfo(
 	return f.operatorInfo, true
 }
 
-func TestAvsRegistryServiceChainCaller_getOperatorPubkeys(t *testing.T) {
+func TestAvsRegistryServiceChainCaller_GetOperatorPubkeys(t *testing.T) {
 	logger := testutils.GetTestLogger()
-	testOperator1 := fakes.TestOperator{
+	var defaultInput = struct {
+		OperatorAddr types.OperatorAddr `json:"operator_address"`
+		OperatorId   string             `json:"operator_id"`
+	}{
 		OperatorAddr: common.HexToAddress("0x1"),
-		OperatorId:   types.OperatorId{1},
+		OperatorId:   "0000000000000000000000000000000000000000000000000000000000000001",
+	}
+	testData := testutils.NewTestData(defaultInput)
+
+	opid, err := hex.DecodeString(testData.Input.OperatorId)
+	if err != nil {
+		t.Fatalf("failed to decode operator id: %v", err)
+	}
+	testOperator1 := fakes.TestOperator{
+		OperatorAddr: testData.Input.OperatorAddr,
+		OperatorId:   types.OperatorId(opid),
 		OperatorInfo: types.OperatorInfo{
 			Pubkeys: types.OperatorPubkeys{
 				G1Pubkey: bls.NewG1Point(big.NewInt(1), big.NewInt(1)),

diff --git a/signerv2/kms_signer_test.go b/signerv2/kms_signer_test.go
@@ -84,7 +84,28 @@ func teardown() {
 	_ = anvil.Terminate(context.Background())
 }
 
-func TestSendTransaction(t *testing.T) {
+func TestSignTransactionWithKmsSigner(t *testing.T) {
+	logger := testutils.GetTestLogger()
+	ethClient, err := ethclient.Dial(anvilEndpoint)
+	assert.Nil(t, err)
+	chainID, err := ethClient.ChainID(context.Background())
+	assert.Nil(t, err)
+	zeroAddr := common.HexToAddress("0x0")
+
+	// read input from JSON if available, otherwise use default values
+	var defaultInput = struct {
+		ChainID big.Int        `json:"chain_id"`
+		Nonce   uint64         `json:"nonce"`
+		To      common.Address `json:"to"`
+		Value   big.Int        `json:"value"`
+	}{
+		ChainID: *big.NewInt(0),
+		Nonce:   0,
+		To:      zeroAddr,
+		Value:   *big.NewInt(1_000_000_000_000_000_000),
+	}
+	testData := testutils.NewTestData(defaultInput)
+
 	c, err := testutils.NewKMSClient(mappedLocalstackPort)
 	assert.Nil(t, err)
 	assert.NotNil(t, keyMetadata.KeyId)
@@ -97,11 +118,6 @@ func TestSendTransaction(t *testing.T) {
 	err = rpcClient.CallContext(context.Background(), nil, "anvil_setBalance", keyAddr, 2_000_000_000_000_000_000)
 	assert.Nil(t, err)
 
-	logger := testutils.GetTestLogger()
-	ethClient, err := ethclient.Dial(anvilEndpoint)
-	assert.Nil(t, err)
-	chainID, err := ethClient.ChainID(context.Background())
-	assert.Nil(t, err)
 	signer := signerv2.NewKMSSigner(context.Background(), c, pk, *keyMetadata.KeyId, chainID)
 	assert.Nil(t, err)
 	assert.NotNil(t, signer)
@@ -110,12 +126,11 @@ func TestSendTransaction(t *testing.T) {
 	assert.NotNil(t, pkWallet)
 	txMgr := txmgr.NewSimpleTxManager(pkWallet, ethClient, logger, keyAddr)
 	assert.NotNil(t, txMgr)
-	zeroAddr := common.HexToAddress("0x0")
 	receipt, err := txMgr.Send(context.Background(), gtypes.NewTx(&gtypes.DynamicFeeTx{
-		ChainID: chainID,
-		Nonce:   0,
+		ChainID: &testData.Input.ChainID,
+		Nonce:   testData.Input.Nonce,
 		To:      &zeroAddr,
-		Value:   big.NewInt(1_000_000_000_000_000_000),
+		Value:   &testData.Input.Value,
 	}), true)
 	assert.Nil(t, err)
 	assert.NotNil(t, receipt)