Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): lint pr titles #1193

Merged
merged 5 commits into from
Feb 28, 2025
Merged

chore(ci): lint pr titles #1193

merged 5 commits into from
Feb 28, 2025

Conversation

0xClandestine
Copy link
Member

@0xClandestine 0xClandestine commented Feb 28, 2025

Motivation:

Improve developer experience by implementing consistent PR title validation.

Before we were validating the commits in a PR, rather than the PR's title.

Modifications:

  • Removed commitlint job from .github/workflows/checks.yml
  • Added PR title validation for conventional commit format: type: description

Result:

We now enforce standardized PR titles following conventional commit format.

@github-actions github-actions bot added 📜 Chore Maintenance related changes (CI, QOL, etc.). ♻️ Refactor Code improvements without changing functionality. labels Feb 28, 2025
@0xClandestine 0xClandestine changed the title bad pr name chore: improve pr commit linting Feb 28, 2025
@0xClandestine 0xClandestine changed the title chore: improve pr commit linting chore: lint pr titles Feb 28, 2025
@0xClandestine 0xClandestine changed the title chore: lint pr titles chore(ci): lint pr titles Feb 28, 2025
@0xClandestine 0xClandestine changed the title chore(ci): lint pr titles bad pr title Feb 28, 2025
@0xClandestine 0xClandestine changed the title bad pr title chore(ci): lint pr titles Feb 28, 2025
@0xClandestine 0xClandestine merged commit 5635ba5 into dev Feb 28, 2025
15 of 16 checks passed
@0xClandestine 0xClandestine deleted the refactor/commitlint branch February 28, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 Chore Maintenance related changes (CI, QOL, etc.). ♻️ Refactor Code improvements without changing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants