test: rounding tests low slashing factors #1178
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8sunyuan
added
🗡️ Slashing Release
eigenmikem
reviewed
Feb 28, 2025
| bytes32[] memory withdrawalRoots = _getWithdrawalHashes(withdrawals); | ||
| check_Undelegate_State(staker, operator, withdrawals, withdrawalRoots, strategies, initDepositShares, 0.toArrayU256()); | ||
|
|
||
| // 6. redeposit (start/complete checkpoint) |
There was a problem hiding this comment.
Should we be actually depositing another 32 ETH and starting a validator in these steps to check that "redepositing" is working?
There was a problem hiding this comment.
Good point, I personally define redeposit as adding shares so this can be either from verify wc of new validators, completing checkpoints, or completing any queued withdrawals.
I'll update this test to randomly choose between those 2 paths on the EigenPod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Testing coverage for rounding edge cases.
Modifications:
Added test file in
Register_Allocate_Slash_VerifyWC_.t.solThe _init setup creates an Operator registered to an OperatorSet who gets slashed down to 1 maxMagnitude.
assert_Snap_StakeBecomeUnslashablegetSlashingFactorfor User.t.solResult:
Added following integration tests
test_slashBC_startCompleteCP_queue_completetest_slash_undelegate_redeposittest_slash_undelegate_completeAsTokens_verifyWCtest_slash_undelegate_completeAsShares_startCompleteCPtest_queueAllShares_completeAsTokensNOTE: currently failing but passes with changes in #1176