Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: beaconchain slashable shares in queue #1087

Merged
merged 1 commit into from
Feb 13, 2025
Merged

fix: beaconchain slashable shares in queue #1087

merged 1 commit into from
Feb 13, 2025

Conversation

0xClandestine
Copy link
Member

@0xClandestine 0xClandestine commented Feb 12, 2025 •
edited
Loading

Motivation:

Fixes an issue where beaconChainETHStrategy queued withdrawals were excluded from slashable shares tracking, leading to undercounted burnable shares. This ensures correct accounting for future ETH burning post-Ethereum Pectra upgrade. (EGSL-03)

Modifications:

  • Removed exclusion of beaconChainETHStrategy in _addQueuedSlashableShares().
  • Updated tests to ensure correct tracking and slashing behavior.

Result:

  • Proper tracking of beaconChainETHStrategy shares in slashing calculations.
  • Accurate burnable share accounting, preparing for future ETH burning.

@ypatil12 ypatil12 changed the title fix: beaconchain slashable shares fix: beaconchain slashable shares in queue Feb 12, 2025
@0xClandestine 0xClandestine force-pushed the fix/beaconchain-slashable-shares branch from b4ccbf3 to 019f85c Compare February 13, 2025 14:41
@0xClandestine 0xClandestine added the ⚖️ Audit Fix Audit-related fixes. label Feb 13, 2025
@0xClandestine 0xClandestine force-pushed the fix/beaconchain-slashable-shares branch from 019f85c to 47d318f Compare February 13, 2025 16:15
@0xClandestine 0xClandestine merged commit fcd2fa3 into slashing-magnitudes-fixes Feb 13, 2025
11 checks passed
@0xClandestine 0xClandestine deleted the fix/beaconchain-slashable-shares branch February 13, 2025 16:39
@wadealexc wadealexc mentioned this pull request Feb 18, 2025
Merged
ypatil12 pushed a commit that referenced this pull request Feb 19, 2025
@0xClandestine @ypatil12
fix: beaconchain slashable shares in queue (#1087)
f2d6816
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@0xClandestine @ypatil12
fix: beaconchain slashable shares in queue (#1087)
dcbbee7
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@0xClandestine @ypatil12
fix: beaconchain slashable shares in queue (#1087)
f843ac1
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@0xClandestine @ypatil12
fix: beaconchain slashable shares in queue (#1087)
616ea70
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@0xClandestine @ypatil12
fix: beaconchain slashable shares in queue (#1087)
54b5e43
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@0xClandestine @ypatil12
fix: beaconchain slashable shares in queue (#1087)
55bd01d
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@0xClandestine @ypatil12
fix: beaconchain slashable shares in queue (#1087)
50153f0
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@0xClandestine @ypatil12
fix: beaconchain slashable shares in queue (#1087)
bcbdb9b
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@0xClandestine @ypatil12
fix: beaconchain slashable shares in queue (#1087)
44bffe2
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@0xClandestine @ypatil12
fix: beaconchain slashable shares in queue (#1087)
6cc5aa5
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@0xClandestine @ypatil12
fix: beaconchain slashable shares in queue (#1087)
e041aec
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@0xClandestine @ypatil12
fix: beaconchain slashable shares in queue (#1087)
5f4e5eb
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@0xClandestine @ypatil12
fix: beaconchain slashable shares in queue (#1087)
f1edd0a
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@0xClandestine @ypatil12
fix: beaconchain slashable shares in queue (#1087)
d58c2ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wadealexc wadealexc wadealexc approved these changes

@ypatil12 ypatil12 ypatil12 approved these changes

@8sunyuan 8sunyuan Awaiting requested review from 8sunyuan

Assignees
No one assigned
Labels
⚖️ Audit Fix Audit-related fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xClandestine @wadealexc @ypatil12