Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add size diff workflow #1065

Merged
merged 6 commits into from
Feb 4, 2025
Merged

Conversation

0xClandestine
Copy link
Member

Motivation:

We're close to size limit on most contracts in core, would be nice to have a way to measure size changes over time.

Modifications:

  • adds a workflow that never fails and reports size differences if any.

Result:

Contributors can quickly see how their changes impact contract sizes.

Needs improvement and to be moved -> Foundry.yml
@0xClandestine 0xClandestine force-pushed the feat/add-size-diff-workflow branch from 7226b34 to e778850 Compare February 4, 2025 14:13
@0xClandestine 0xClandestine merged commit 8a73b8b into dev Feb 4, 2025
6 of 7 checks passed
@0xClandestine 0xClandestine deleted the feat/add-size-diff-workflow branch February 4, 2025 14:59
ypatil12 pushed a commit that referenced this pull request Feb 19, 2025
* feat: add size diff workflow

Needs improvement and to be moved -> Foundry.yml

* fix: ci

* fix: ci

* test: ci

* refactor: improve logging

* chore: remove test variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants