Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow re-arranging popup menu items #5112

Merged
merged 3 commits into from
Jan 5, 2025
Merged

Conversation

SuperDragonXD
Copy link
Collaborator

@SuperDragonXD SuperDragonXD commented Dec 22, 2024

Description

This feature allows users to re-order and toggle specific items in the pop-up menu.

Below is a screenshot of the feature:
Screenshot_20250104-153859.jpg

Type of change

❌ General change (non-breaking change that doesn't fit the below categories like copyediting)
❌ Bug fix (non-breaking change which fixes an issue)
✅ New feature (non-breaking change which adds functionality)
❌ Breaking change (fix or feature that would cause existing functionality to not work as expected)

@SuperDragonXD
Copy link
Collaborator Author

SuperDragonXD commented Jan 4, 2025

As a note: would prefer rebasing this to the dev branch (manually) instead of squash-merging. It's up to you guys though.

@SuperDragonXD SuperDragonXD marked this pull request as ready for review January 4, 2025 07:38
@SuperDragonXD SuperDragonXD force-pushed the feat/reorder-popup-items branch from 7cdde9d to d48a60e Compare January 4, 2025 10:11
@MrSluffy MrSluffy merged commit c2665df into 15-dev Jan 5, 2025
5 checks passed
@MrSluffy MrSluffy deleted the feat/reorder-popup-items branch January 5, 2025 00:30
@istudyatuni
Copy link

There is a bug: when the home screen is locked, popup closes almost immediately after opening (not sure if it belongs to this PR, but I guess yes)

Also it seems that the old setting has not migrated: I had "Show lock button" turned on, but it was disabled in new settings

Also, I think it should be possible to enable/disable items like "Edit home screen" even when home screen is locked

@SuperDragonXD
Copy link
Collaborator Author

SuperDragonXD commented Jan 5, 2025

There is a bug: when the home screen is locked, popup closes almost immediately after opening (not sure if it belongs to this PR, but I guess yes)

Will likely need to move the check (when the home screen is locked) to the preference area; thanks for catching this issue.

Also it seems that the old setting has not migrated: I had "Show lock button" turned on, but it was disabled in new settings

Preferences migration hasn't been implemented (yet). Will look into it when I have the time.

Also, I think it should be possible to enable/disable items like "Edit home screen" even when home screen is locked

It doesn't really make sense that you are able to edit the home screen or add widgets while the home screen is locked, so I've purposefully disabled that option.

@istudyatuni
Copy link

It doesn't really make sense that you are able to edit the home screen or add widgets while the home screen is locked

Yes, but I'm talking about editing it in the added settings - you can't enable/disable this when home screen is locked. Previous behavior was the same (not able to toggle), but I think allowing this would be better. Maybe it's better to create a separate issue?

@SuperDragonXD
Copy link
Collaborator Author

Yes, but I'm talking about editing it in the added settings - you can't enable/disable this when home screen is locked. Previous behavior was the same (not able to toggle), but I think allowing this would be better. Maybe it's better to create a separate issue?

Allowing this behavior doesn't make sense as you should not be able to add or edit widgets when the home screen is locked. Same goes for re-arranging icons: if the home screen is locked, you can not go to edit mode and re-arrange the icons there.

Because of this, the items "Widgets" & "Edit home screen" automatically turn off (get hidden) and disabled when the home screen is locked.

@istudyatuni
Copy link

Hmm, okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants