Add a switch to control suggested apps showing

[Goooler]

Description

Enabled:

Disabled:

Type of change

❌ General change (non-breaking change that doesn't fit the below categories like copyediting)
❌ Bug fix (non-breaking change which fixes an issue)
✅ New feature (non-breaking change which adds functionality)
❌ Breaking change (fix or feature that would cause existing functionality to not work as expected)

[Goooler]

Seems recent apps were shown when Recents are enabled, should we check if Recents is available?

[suphon-t]

There’s already an option for this, at least it was in 12.1.
Home Settings -> App Drawer -> Suggestions -> Suggestions in all apps list

[Goooler]

Seems not.

lawnchair/lawnchair/src/app/lawnchair/ui/preferences/AppDrawerPreferences.kt

Line 61 in 171cbbe

SuggestionsPreference()

[MrSluffy]

We already have option of this

[Goooler]

I know why, I can't see this Suggestions entry although I've granted PACKAGE_USAGE_STATS permission for Lawnchair, and there is no ACTION_CONTENT_SUGGESTIONS_SETTINGS activity on my OS.

2023-12-01 02:34:01.076 18520-18520 AndroidRuntime          app.lawnchair.debug                  E  FATAL EXCEPTION: main (Ask Studio Bot)
Process: app.lawnchair.debug, PID: 18520
android.content.ActivityNotFoundException: No Activity found to handle Intent { act=android.settings.ACTION_CONTENT_SUGGESTIONS_SETTINGS }

[MrSluffy]

I know why, I can't see this Suggestions entry although I've granted PACKAGE_USAGE_STATS permission for Lawnchair, and there is no ACTION_CONTENT_SUGGESTIONS_SETTINGS activity on my OS.

2023-12-01 02:34:01.076 18520-18520 AndroidRuntime          app.lawnchair.debug                  E  FATAL EXCEPTION: main (Ask Studio Bot)
Process: app.lawnchair.debug, PID: 18520
android.content.ActivityNotFoundException: No Activity found to handle Intent { act=android.settings.ACTION_CONTENT_SUGGESTIONS_SETTINGS }

Oh I see, maybe try updating ASI and Google app

[Goooler]

In this case, can we keep this flag to control the suggestions' visibility, maybe I should merge this option into SuggestionsPreference()?

[MrSluffy]

In this case, can we keep this flag to control the suggestions' visibility, maybe I should merge this option into SuggestionsPreference()?

Maybe add some check, only show if this occur? android.content.ActivityNotFoundException: No Activity found to handle Intent { act=android.settings.ACTION_CONTENT_SUGGESTIONS_SETTINGS }

[Goooler]

This check is enough.

lawnchair/lawnchair/src/app/lawnchair/ui/preferences/components/SuggestionsPreference.kt

Lines 19 to 21 in e968788

	if (usagePerm == PackageManager.PERMISSION_GRANTED &&
	context.packageManager.resolveActivity(intent, 0) != null
	) {

[MrSluffy]

This check is enough.

lawnchair/lawnchair/src/app/lawnchair/ui/preferences/components/SuggestionsPreference.kt

Lines 19 to 21 in e968788

	if (usagePerm == PackageManager.PERMISSION_GRANTED &&
	context.packageManager.resolveActivity(intent, 0) != null
	) {

yeah look great

[suphon-t]

This would be confusing if the user's device doesn't have a suggestions service and this toggle appears. A better way would be to investigate why your device has a suggestion service but not the activity.

[Goooler]

I found this issue when I set Lawnchair as the QS provider, even if I fallback to the default QS provider, suggested apps are still showing.

[Goooler]

We probably merge this first, for the ones who need this. Look back on this later.