fixed 3p themed icons not applying

- closes : #4799 - closes : #4752 - closes : #4267 - closes : #4248 - closes : #4179 - closes : #4157 - closes : #3960 - closes : #3943 - closes : #3408 - closes : #2882
LawnchairLauncher · Jan 1, 2025 · b684505 · b684505
1 parent 31dfcc8
commit b684505
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 8 deletions.
diff --git a/platform_frameworks_libs_systemui b/platform_frameworks_libs_systemui
diff --git a/src/com/android/launcher3/Utilities.java b/src/com/android/launcher3/Utilities.java
@@ -764,6 +764,10 @@ public static <T extends Context & ActivityContext> Pair<AdaptiveIconDrawable, D
             badge = icon.getBadge();
         }
 
+        if (useTheme && mainIcon instanceof BitmapInfo.Extender) {
+            mainIcon = ((BitmapInfo.Extender) mainIcon).getThemedDrawable(context);
+        }
+
         if (mainIcon == null) {
             return null;
         }

diff --git a/src/com/android/launcher3/icons/ComponentWithLabelAndIcon.java b/src/com/android/launcher3/icons/ComponentWithLabelAndIcon.java
@@ -44,14 +44,14 @@ public ComponentWithIconCachingLogic(Context context, boolean addToMemCache) {
         @NonNull
         @Override
         public BitmapInfo loadIcon(@NonNull Context context,
-                @NonNull ComponentWithLabelAndIcon object) {
+                                   @NonNull ComponentWithLabelAndIcon object) {
             Drawable d = object.getFullResIcon(LauncherAppState.getInstance(context)
-                    .getIconCache());
+                .getIconCache());
             if (d == null) {
                 return super.loadIcon(context, object);
             }
             try (LauncherIcons li = LauncherIcons.obtain(context)) {
-                return li.createBadgedIconBitmap(d);
+                return li.createBadgedIconBitmap(d, new BaseIconFactory.IconOptions().setUser(object.getUser()));
             }
         }
     }

diff --git a/src/com/android/launcher3/icons/LauncherActivityCachingLogic.java b/src/com/android/launcher3/icons/LauncherActivityCachingLogic.java
@@ -67,7 +67,8 @@ public CharSequence getLabel(@NonNull LauncherActivityInfo object) {
     public BitmapInfo loadIcon(@NonNull Context context, @NonNull LauncherActivityInfo object) {
         try (LauncherIcons li = LauncherIcons.obtain(context)) {
             return li.createBadgedIconBitmap(LauncherAppState.getInstance(context)
-                            .getIconProvider().getIcon(object, li.mFillResIconDpi));
+                    .getIconProvider().getIcon(object, li.mFillResIconDpi),
+                new BaseIconFactory.IconOptions().setUser(object.getUser()));
         }
     }
 }
diff --git a/src/com/android/launcher3/model/WidgetItem.java b/src/com/android/launcher3/model/WidgetItem.java
@@ -48,7 +48,7 @@ public WidgetItem(LauncherAppWidgetProviderInfo info,
         super(info.provider, info.getProfile());
 
         label = iconCache.getTitleNoCache(info);
-        description = ATLEAST_S ? info.loadDescription(context) : null;
+        description = ATLEAST_S && info.loadDescription(context) != null ? info.loadDescription(context) : "";
         widgetInfo = info;
         activityInfo = null;
 

diff --git a/src/com/android/launcher3/model/data/ItemInfoWithIcon.java b/src/com/android/launcher3/model/data/ItemInfoWithIcon.java
@@ -23,7 +23,6 @@
 import androidx.annotation.Nullable;
 
 import com.android.launcher3.Flags;
-import com.android.launcher3.Utilities;
 import com.android.launcher3.icons.BitmapInfo;
 import com.android.launcher3.icons.FastBitmapDrawable;
 import com.android.launcher3.logging.FileLog;
@@ -328,7 +327,7 @@ public FastBitmapDrawable newIcon(Context context, boolean applyTheme) {
      * Returns a FastBitmapDrawable with the icon and context theme applied
      */
     public FastBitmapDrawable newIcon(Context context, @BitmapInfo.DrawableCreationFlags int creationFlags) {
-        FastBitmapDrawable drawable = bitmap.newIcon(context, creationFlags);
+        FastBitmapDrawable drawable = (creationFlags & BitmapInfo.FLAG_THEMED) != 0 ? bitmap.newThemedIcon(context) : bitmap.newIcon(context, creationFlags);
         drawable.setIsDisabled(isDisabled());
         return drawable;
     }
+3 −4		iconloaderlib/src/com/android/launcher3/icons/BaseIconFactory.java
+41 −5		iconloaderlib/src/com/android/launcher3/icons/BitmapInfo.java
+2 −2		iconloaderlib/src/com/android/launcher3/icons/FastBitmapDrawable.java
+3 −0		iconloaderlib/src/com/android/launcher3/icons/GraphicsUtils.java
+90 −58		iconloaderlib/src/com/android/launcher3/icons/ThemedIconDrawable.java
+3 −11		iconloaderlib/src/com/android/launcher3/icons/cache/BaseIconCache.java