Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more function from torch::cuda #500

Merged
merged 8 commits into from
Dec 1, 2022
Merged

Add more function from torch::cuda #500

merged 8 commits into from
Dec 1, 2022

Conversation

vcarpani
Copy link
Contributor

@vcarpani vcarpani commented Jun 22, 2022 •
edited
Loading

This PR adds some more torch::cuda functions and improves documentation for the existing ones.

@vcarpani vcarpani marked this pull request as ready for review July 5, 2022 12:04
@vcarpani vcarpani force-pushed the add-features branch 5 times, most recently from 4e96416 to 158b7cc Compare July 5, 2022 13:55
@vcarpani
Copy link
Contributor Author

Hello, any updates on this?

In addition to that, my company is really interested in supporting this project since we are using it in production, can we help in any way with the maintenance of this repo?

LaurentMazare
LaurentMazare reviewed Oct 10, 2022
View reviewed changes
@LaurentMazare
Copy link
Owner

Sorry for the delay, I've added some comments. It's great to know that this is used in production, it would probably be helpful to know a bit more on how it's used / if there are some repos based on it so as to involve you e.g. when potentially introducing breaking changes.

@vcarpani
Copy link
Contributor Author

vcarpani commented Oct 10, 2022 •
edited
Loading

Sorry for the delay, I've added some comments. It's great to know that this is used in production, it would probably be helpful to know a bit more on how it's used / if there are some repos based on it so as to involve you e.g. when potentially introducing breaking changes.

No problems about the delay, thanks for maintaining this repo. We are currently using it in 2 different repos, one using the JIT loader and the other one using torch operators directly.

For breaking changes, I would propose to use a CHANGELOG file, if you believe it is a good idea, I can open a PR on the CHANGELOG format, so that all the people using the repo would have an idea of what changed and which version to be used in their production environments

LaurentMazare
LaurentMazare reviewed Dec 1, 2022
View reviewed changes
CHANGELOG.md Outdated
@@ -3,7 +3,11 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## v0.10.0 - not released yet
## Unreleased
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you revert this line to mentioning v0.10.0 as it's the version in the Cargo.toml on the github tip.

CHANGELOG.md Outdated
## v0.10.0 - not released yet
## Unreleased
### Added
- Expose functions for setting manual seeds for CUDA devices.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a link to the PR?

@vcarpani
Copy link
Contributor Author

vcarpani commented Dec 1, 2022

Should be solved now ;)

@LaurentMazare LaurentMazare merged commit fe1aecb into LaurentMazare:main Dec 1, 2022
@LaurentMazare
Copy link
Owner

Merged, thanks for the PR!

@vcarpani vcarpani deleted the add-features branch December 2, 2022 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurentMazare LaurentMazare LaurentMazare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vcarpani @LaurentMazare