Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wrap __ to the hardcoded text to allow translation #9

Merged
merged 1 commit into from
Oct 30, 2021

Conversation

chengkangzai
Copy link
Contributor

Hi, laravel daily team, great work on this project.

I just spotted some parts of the stub do not have __() function wrapped for the translation feature so this is why I open this PR.

i do not touch laravel UI folder as it looks like still under construction.

@PovilasKorop PovilasKorop merged commit 0ea8d6c into LaravelDaily:main Oct 30, 2021
@PovilasKorop
Copy link
Collaborator

Great thanks @chengkangzai !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants