Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[it]: Fix italian increase decrease #4160

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

trippo
Copy link
Contributor

@trippo trippo commented Jan 11, 2024

No description provided.

@andrey-helldar andrey-helldar changed the title Fix italian increase decrease [it]: Fix italian increase decrease Jan 11, 2024
@trippo
Copy link
Contributor Author

trippo commented Jan 11, 2024

Viene usato qua in nova nelle metrics, non so se in altre parti.
aumentare e dimunire non ha senso in questo contesto perché usa sostantivi non verbi

image

@masterix21
Copy link
Member

masterix21 commented Jan 11, 2024

@trippo: Nel tuo contesto è corretto quello che suggerisci, ma dovremmo prima verificare tutti gli utilizzi.

@andrey-helldar: do you have a way to understand when (and where) these two translations are used? Because we should know the context to understand the best choice. @trippo found these in the Nova metrics only.

@trippo
Copy link
Contributor Author

trippo commented Jan 11, 2024

Potremmo anche usare il participio passato Aumentato/Diminuito

@andrey-helldar
Copy link
Member

@masterix21, the translation of these words is used in Laravel Nova.

I don’t use this admin panel myself, but I found a mention in the documentation in the metric: https://nova.laravel.com/docs/4.0/metrics/defining-metrics.html#value-metrics

image

@andrey-helldar
Copy link
Member

@trippo, @masterix21, I think it's also worth checking the translation of the No Increase phrase.

@masterix21
Copy link
Member

Potremmo anche usare il participio passato Aumentato/Diminuito

Visto che l'utilizzo al momento è limitato alle metriche di Nova, credo sia meglio aumento e diminuzione. Vada per questo.

@trippo, @masterix21, I think it's also worth checking the translation of the No Increase phrase.

It is ok: no changes are needed here.

@masterix21
Copy link
Member

@andrey-helldar, PR approved.

Copy link
Member

@andrey-helldar andrey-helldar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie

@andrey-helldar andrey-helldar merged commit b759f3e into Laravel-Lang:main Jan 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants