-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Some translations have been lost in the new version (10.0) #1762
Fix: Some translations have been lost in the new version (10.0) #1762
Conversation
Checking internally Laravel code it seems the only translation that does not match the search patterns that you handle is
__($exception->getMessage() ?: 'Forbidden') I consider that this key needs to be added manually. Multi-line keys apparently only exist for notification mails subcopy slot ...
@lang(
"If you’re having trouble clicking the \":actionText\" button, copy and paste the URL below\n".
'into your web browser:',
[
'actionText' => $actionText,
]
) <span class="break-all">[{{ $displayableActionUrl }}]({{ $actionUrl }})</span>
... |
@andrey-helldar I have checked de.json and de/jetstream.json, the translations are correct. I did not check for missing translation keys. |
…2-46 # Conflicts: # locales/pt_BR/packages/cashier.json # locales/pt_BR/packages/jetstream.json # locales/pt_BR/packages/nova.json # locales/pt_BR/packages/spark-paddle.json # locales/pt_BR/packages/spark-stripe.json # locales/tr/packages/cashier.json # locales/tr/packages/jetstream.json # locales/tr/packages/nova.json # locales/tr/packages/spark-paddle.json # locales/tr/packages/spark-stripe.json # locales/tr/tr.json
@Laravel-Lang/laravel-lang, guys, check this one PR, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see if I understand your idea.
- In the
source
folder it only contains arrays with the keys (only keys without translations) used in the{locale}.json
base and all packages including repetitions if necessary (for examplebreeze
andjetstream
share several keys therefore they appear in both files). - In
locales
folder a single filelocales/{locale}/{locale}.json
with all mixed keys with translations and a unique translation.
I think it is a great idea!! Just a question, Are the keys within the packages still searched automatically?
So I think an excellent job has been done, ¡APPROVED!
Yes
Yes
Auto-search (these projects do not have json and php files with translations):
Manually copying files (these projects have json or php files with translations):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some questions on code
@andrey-helldar excellent job! I skimmed |
Just in case, I'll write how I worked with translations:
|
I merge this pull request, and I create a v10.1 |
thank you |
Thank you @andrey-helldar and the rest for the great work and suggestions have done. |
@mohamedsabil83, thank you! I hope you are doing well with your health now. |
Thank you for asking @andrey-helldar. I am currently recovering and will be back to work soon. |
locales/{locale}/packages
folder;locales/{locale}/packages
folders;source/packages
folder;laravel/framework
version 6 project and save them tosource/en.json
file;laravel/framework
version 7 project and save them tosource/en.json
file;laravel/framework
version 8 project and save them tosource/en.json
file;app/excludes.php
;app/keys.php
;app/packages.php
;app/status.php
;app/split-packages.php
;