Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fa]: Fix out of context bot translations #496

Merged
merged 6 commits into from
Mar 23, 2024

Conversation

mokhosh
Copy link
Contributor

@mokhosh mokhosh commented Mar 13, 2024

This fixes AI generated translations which are honestly terrible.

Question with a little context: In English the infinitive form and the imperative form are the same in many situations. Like in the case of "add", and sometimes they're different, like you have "impersonate" and "impersonation" in these files.
In Farsi, they are almost always different. Which one do you think should we default to, the infinitive form, or the imperative?

This can be merged regardless of the question above, since I've tried to stick to Farsi applications terminology.

@andrey-helldar
Copy link
Member

When translating into other languages, the same problem occurs. I think you should use the infinitive form of the verb, as it is most often appropriate in the context. But I could be wrong.

@Laravel-Lang/laravel-lang, what do you think about using the verb form?

@ariaieboy
Copy link
Member

@mokhosh
خیلی ممنون بابت مشارکت شما در این پروژه یکسری موارد فکر میکنم میشه بیشتر روش کار کرد و کامنت گذاشتم.
یک هم فکری بکنیم و این موارد بهبود بدیم بعد مرج کنیم فکر میکنم بهتر باشه

@andrey-helldar andrey-helldar changed the title [fa] fix out of context bot translations [fa]: Fix out of context bot translations Mar 13, 2024
Copy link
Member

@ariaieboy ariaieboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

لطفا موارد ذکر شده را بررسی کنید

andrey-helldar and others added 2 commits March 23, 2024 14:23
Co-authored-by: AriaieBOY <ariaieboy.ir@gmail.com>
Co-authored-by: AriaieBOY <ariaieboy.ir@gmail.com>
@andrey-helldar
Copy link
Member

ممنون

@andrey-helldar andrey-helldar merged commit 20f4a1d into Laravel-Lang:main Mar 23, 2024
10 checks passed
@mokhosh mokhosh deleted the fix-fa branch March 23, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants