Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRUD v5 support #82

Merged
merged 5 commits into from
Mar 7, 2022
Merged

CRUD v5 support #82

merged 5 commits into from
Mar 7, 2022

Conversation

promatik
Copy link
Contributor

Can we have it? I'm actually using this package on my boilerplate, so I was not able to upgrade yet.
By the way, I can't see a way to test this with v5, because I can't install it on a v5 demo project.

@tabacitu
Copy link
Member

tabacitu commented Feb 14, 2022

Yup, sure. For future reference, we have an article on our blog that explains how to force-install a package, even if Composer won't let you - https://backpackforlaravel.com/articles/tutorials/how-to-submit-a-non-trivial-PR-to-a-Laravel-package

Present-me would probably word the title a little bit better than past-me 😅

Please install it like that, test it and see if any other changes are needed. I have a feeling something will be needed, since the lang directory has moved in L9, from resources/lang to lang. But other stuff might break too... 🤷‍♂️

@tabacitu
Copy link
Member

tabacitu commented Feb 14, 2022

So to install this in my v5 project right now, I'd do:

# step 1
git clone git@github.com:Laravel-Backpack/LangFileManager.git vendor/backpack/langfilemanager

# step 2
# add the service provider (config\app.php)

# step 3
# add the autoload to composer.json

# step 4
composer dump-autoload

# step 5
# follow its installation docs

Then you'd have it cloned in vendor/backpack/langfilemanager, just like it were installed. When you're done making changes, you can just undo all of the above.

@tabacitu tabacitu mentioned this pull request Feb 14, 2022
@guleswine
Copy link

How is it going? I'm really looking forward to the dependency update :)

composer.json Show resolved Hide resolved
@promatik promatik requested a review from tabacitu March 6, 2022 01:20
@promatik promatik assigned tabacitu and unassigned promatik Mar 6, 2022
@tabacitu tabacitu merged commit 7d6e58b into master Mar 7, 2022
@tabacitu tabacitu deleted the v5-support branch March 7, 2022 08:47
@tabacitu tabacitu mentioned this pull request Mar 7, 2022
@guleswine
Copy link

Hurrah!

@tabacitu
Copy link
Member

tabacitu commented Mar 7, 2022

I know right?! 😅

@guleswine please notice there's a small change - if you're using the FREE version of Backpack, in the Language form the browse field will become a text field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants