Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output code style (Fixes #28) #64

Merged
merged 6 commits into from
Jun 26, 2020

Conversation

yusufkandemir
Copy link
Contributor

This PR aims to fix #28

Changes

  • Added trailing comma to arrays.
  • Added a new line at end of file.
  • Changed double quotes to single quotes.
  • Changed booleans from uppercase to lowercase.
  • Removed extra space after php tag, extra space before return.
  • Changed detection of number indexed elements from array-based to element-based.

Added trailing comma to arrays.
Added a new line at end of file.
Changed double quotes to single quotes.
Changed booleans from uppercase to lowercase.
Removed extra space after php tag, extra space before return.
Changed detection of number indexed elements from array-based to element-based.
@welcome
Copy link

welcome bot commented Oct 8, 2018

BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.

Please keep in mind that:

  • if this constitutes a breaking change, it might take quite a while for this to get merged; we try to emulate the Laravel release cycle as much as possible, so developers can upgrade both software once; this means a new big release every ~6 months;
  • even if it's a non-breaking change, it might take a few days/weeks for the PR to get merged; unless it's a no-brainer, we like to have some community feedback on new features, before we merge them; this leads to higher-quality code, in the end; we learnt this the hard way :-)
  • not all PRs get merged; sometimes we just have to hold out new features, to keep the packages lean; sometimes we don't include features that only apply to niche use cases;
  • we're not perfect; if you think we're wrong, call us out on it; but in a kind way :-) we all make mistakes, best we learn from them and build better software together;

Thank you!

--
Justin Case
The Backpack Robot

Copy link
Member

@tabacitu tabacitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tabacitu
Copy link
Member

tabacitu commented Oct 9, 2018

Wow - thank you @yusufkandemir - sounds a lot better to me.

@AlinGhitu this is your baby - what do you think?

@Ghitu
Copy link
Contributor

Ghitu commented Oct 9, 2018

@tabacitu We should merge it.

@AbbyJanke
Copy link

@tabacitu Been here for awhile, but I just tested it on 4.1 and has no issues. Any chance of getting it merged?

@tabacitu
Copy link
Member

Wow - indeed this has been waiting for quite some time now. Sorry for taking so long @yusufkandemir , @Ghitu and @AbbyJanke . Thanks a lot for confirming it works well @AbbyJanke , merging and tagging right now! Let me know if you encounter any issues.

PS. I don't use this package very often - if at all. So if anybody else wants to maintain it, I'm more than happy to give the reigns over, so it gets the attention it deserves. Alternatively, if anybody creates a better package (read - one that actually stores the lang strings in the db, then caches them, instead of actually modifying files in production - like suggested in #3), then I'd be more than happy to deprecate this package and forward everybody to use the new one.

@tabacitu tabacitu merged commit 074b7ea into Laravel-Backpack:master Jun 26, 2020
@welcome
Copy link

welcome bot commented Jun 26, 2020

WHOOP-WHOOP! Congrats, your first PR on this repo has officialy been merged.

party

If you want to help out the community in other ways, you can:

  • give your opinion on other Github Issues & PRs;
  • chat with others in the Gitter Chatroom (usually for quick help: How do I do X);
  • answer Backpack questions on Stackoverflow; you get points, people get help; you can subscribe to the backpack-for-laravel tag by adding a new filter; that will send you emails when new questions come up with our tag;

Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-)
Cheers!

--
Justin Case
The Backpack Robot

P.S. Help in the Backpack community is rewarded with free Backpack commercial licenses. It's the least we can do. If you feel you've helped the community with PRs, help & other stuff, please shoot Tabacitu an email and ask him if you qualify for free licenses. You scratch my back, I scratch your back. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saved file should be formatted to coding standard
4 participants