-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix output code style (Fixes #28) #64
Fix output code style (Fixes #28) #64
Conversation
Added trailing comma to arrays. Added a new line at end of file. Changed double quotes to single quotes. Changed booleans from uppercase to lowercase. Removed extra space after php tag, extra space before return. Changed detection of number indexed elements from array-based to element-based.
BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly. Please keep in mind that:
Thank you! -- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Wow - thank you @yusufkandemir - sounds a lot better to me. @AlinGhitu this is your baby - what do you think? |
@tabacitu We should merge it. |
@tabacitu Been here for awhile, but I just tested it on 4.1 and has no issues. Any chance of getting it merged? |
Wow - indeed this has been waiting for quite some time now. Sorry for taking so long @yusufkandemir , @Ghitu and @AbbyJanke . Thanks a lot for confirming it works well @AbbyJanke , merging and tagging right now! Let me know if you encounter any issues. PS. I don't use this package very often - if at all. So if anybody else wants to maintain it, I'm more than happy to give the reigns over, so it gets the attention it deserves. Alternatively, if anybody creates a better package (read - one that actually stores the lang strings in the db, then caches them, instead of actually modifying files in production - like suggested in #3), then I'd be more than happy to deprecate this package and forward everybody to use the new one. |
WHOOP-WHOOP! Congrats, your first PR on this repo has officialy been merged. If you want to help out the community in other ways, you can:
Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-) -- P.S. Help in the Backpack community is rewarded with free Backpack commercial licenses. It's the least we can do. If you feel you've helped the community with PRs, help & other stuff, please shoot Tabacitu an email and ask him if you qualify for free licenses. You scratch my back, I scratch your back. Thank you! |
This PR aims to fix #28
Changes