Dont call mutators as methods #5647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip] [skip ci]
[ci skip] [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
Not previously tested, broken 🤷♂️
We had a use-case outside of our test suite that was reported in #5645
When developer added an
Attribute(an accessor/mutator) as the last parameter of a relation string, we would wrongfully interpret it as a relationship.AFTER - What is happening after this PR?
We properly infer that's not a relationship. Added tests for that scenario too, nothing else is broken, we should be fine 👍
HOW
How did you achieve that, in technical terms?
Wrote the test, expect it to fail, it failed, fixed the relevant code, all green 🟢
Is it a breaking change?
No
How can we test the before & after?
As @karandatwani92 pointed out in #5645 (comment)