Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does FoLiA-benchmark a good job? #48

Closed
kosloot opened this issue Oct 5, 2020 · 1 comment
Closed

does FoLiA-benchmark a good job? #48

kosloot opened this issue Oct 5, 2020 · 1 comment
Assignees

Comments

@kosloot
Copy link
Contributor

kosloot commented Oct 5, 2020

in line 207, FoLiA-benchmark selects all the Word* 's of a Document.
But the result is never used!
I assume the compiler will optimize this selection away, making this test overly optimistic about the speed.

This could be fixed by using the selection in for instance an output statement telling it's size.

@proycon
Copy link
Member

proycon commented Oct 5, 2020

Hmm, good point, I may have forgotten to take compiler optimisation into account there.

proycon added a commit that referenced this issue Oct 5, 2020
@proycon proycon closed this as completed Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants