Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ceizak NM - Transcendent Scorpion HP, Level & Skill Adjustments #7015

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Ceizak NM - Transcendent Scorpion HP, Level & Skill Adjustments #7015

merged 1 commit into from
Feb 13, 2025

Conversation

Yuchemey
Copy link
Contributor

@Yuchemey Yuchemey commented Feb 11, 2025 •
edited
Loading

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

##What does this pull request do?

  • Implements Transcendent Scorpion in Ceizak Battlegrounds (I-10).
  • Adds HP, level, mob skills, and behavior to the NM.
  • NM gains three additional mob skills when its HP drops below 50%.

##How to test these changes

  1. Travel to Ceizak Battlegrounds (I-10) or use: !pos 160 0 -400 261
  2. Obtain item Celadon Ygrette Shard IV (!additem 6013).
  3. Trade the item to the nearby ??? to spawn the NM.
  4. Engage in combat and verify:
  • Above 50% HP → NM uses three initial mob skills.
  • Below 50% HP → NM gains three additional mob skills.

@Yuchemey Yuchemey force-pushed the base branch 5 times, most recently from f107fd7 to 1b1526b Compare February 11, 2025 08:17
zach2good
zach2good reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor

@zach2good zach2good left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content seems fine, just needs styling 👍

scripts/zones/Ceizak_Battlegrounds/mobs/Transcendent_Scorpion.lua Outdated
Comment on lines 11 to 20
xi.effect.FLASH, xi.effect.BLINDNESS, xi.effect.ELEGY, xi.effect.REQUIEM,
xi.effect.PARALYSIS, xi.effect.POISON, xi.effect.DISEASE, xi.effect.PLAGUE,
xi.effect.WEIGHT, xi.effect.BIND, xi.effect.BIO, xi.effect.DIA, xi.effect.BURN,
xi.effect.FROST, xi.effect.CHOKE, xi.effect.RASP, xi.effect.SHOCK, xi.effect.DROWN,
xi.effect.STR_DOWN, xi.effect.DEX_DOWN, xi.effect.VIT_DOWN, xi.effect.AGI_DOWN,
xi.effect.INT_DOWN, xi.effect.MND_DOWN, xi.effect.CHR_DOWN, xi.effect.ADDLE, xi.effect.SLOW,
xi.effect.HELIX, xi.effect.ACCURACY_DOWN, xi.effect.ATTACK_DOWN, xi.effect.EVASION_DOWN,
xi.effect.DEFENSE_DOWN, xi.effect.MAGIC_ACC_DOWN, xi.effect.MAGIC_ATK_DOWN,
xi.effect.MAGIC_EVASION_DOWN, xi.effect.MAGIC_DEF_DOWN, xi.effect.MAX_TP_DOWN,
xi.effect.MAX_MP_DOWN, xi.effect.MAX_HP_DOWN
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can be indented, and a single entry per line

scripts/zones/Ceizak_Battlegrounds/mobs/Transcendent_Scorpion.lua Outdated
Comment on lines 24 to 32
local numEffectsRemoved = 0
for _, effect in ipairs(removables) do
if mob:hasStatusEffect(effect) then
mob:delStatusEffect(effect)
numEffectsRemoved = numEffectsRemoved + 1
end
end

return numEffectsRemoved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs indenting

scripts/zones/Ceizak_Battlegrounds/mobs/Transcendent_Scorpion.lua Outdated
end

entity.onMobFight = function(mob, target)
if mob:getHPP() <= 50 then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs indenting

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also going to be setting the skill list every tick - which is harmless, but worth knowing for the future

scripts/zones/Ceizak_Battlegrounds/mobs/Transcendent_Scorpion.lua Outdated
end

entity.onMobSpawn = function(mob)
mob:addListener('WEAPONSKILL_USE', 'ALL_MOBSKILL_CHECK', function(mobArg, target, skillID, tp, action)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs indenting

@Yuchemey Yuchemey force-pushed the base branch 4 times, most recently from 609bec2 to c94c9e6 Compare February 12, 2025 17:44
@zach2good zach2good merged commit 6052395 into LandSandBoat:base Feb 13, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zach2good zach2good zach2good left review comments

@WinterSolstice8 WinterSolstice8 WinterSolstice8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yuchemey @zach2good @WinterSolstice8