Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Rapid Shot on Throwing weapons and adjust delay reduction #6992

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

Flam9
Copy link
Contributor

@Flam9 Flam9 commented Feb 8, 2025

Sources:

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Disable Rapid Shot on Throwing Weapons
  • Adjust delay to 2-50% from 6-50%

Steps to test these changes

Gear

  • Bandits gun lvl 15: !giveitem Flam 17257 1
  • Bullet: !giveitem Flam 17340 99
  • Dart: !giveitem Flam 17307 99

Steps

  • Be a RNG or COR (!changejob 17) lvl 15+
  • Equip darts, spam /ra <t> and time attack durations with stopwatch. Notice no changes after ~20 autos.
  • Equip gun, do ^

@WinterSolstice8 WinterSolstice8 added the squash Reminder to squash commits before/on merge (you can do this, or maintainers will do this for you) label Feb 9, 2025
@WinterSolstice8
Copy link
Member

Ugh, you're telling me BG has two pages that say two different things and one matches JP wiki and that's the wrong reduction for rapid shot? nice...

At least Byrth had a better explanation that actually makes sense

@Flam9
Copy link
Contributor Author

Flam9 commented Feb 9, 2025

Done, and I squashed it too

@LandSandBoat LandSandBoat deleted a comment from github-actions bot Feb 10, 2025
@Xaver-DaRed Xaver-DaRed removed the squash Reminder to squash commits before/on merge (you can do this, or maintainers will do this for you) label Feb 10, 2025
@claywar claywar merged commit eb1dcb8 into LandSandBoat:base Feb 10, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants