Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magic] Fix duplicate message on death spell AND enemy Death spell not landing ever #6148

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

Xaver-DaRed
Copy link
Contributor

@Xaver-DaRed Xaver-DaRed commented Aug 23, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Fixes mob death not ever working. Fuck you players.
Fixes duplicate "Falls to the ground" message when death lands.

Steps to test these changes

Get a mob to cast death on you.
Actually die.

@claywar claywar merged commit b633ba8 into LandSandBoat:base Aug 24, 2024
13 checks passed
@Xaver-DaRed Xaver-DaRed deleted the death branch August 25, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants