Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BCNM] Add Waking the Beast Ifrit BCNM #6140

Merged

Conversation

TracentEden2
Copy link
Contributor

@TracentEden2 TracentEden2 commented Aug 22, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

This PR adds the waking the beast Ifrit BCNM fight. This is the first in a series of PRs for adding WTB. Note that this does not add the actual quest so players cannot yet enter the BCNM fight, as my plan is to add all of the BCNM fights before a final PR that adds in the quest. Also note that the commented out -- mob:setMobMod(xi.mobMod.SKIP_ALLEGIANCE_CHECK, 1) will be enabled once this related PR that adds the specific mob mod is merged.

I am not sure if this should be marked as experimental or not?

The info for the PR has been taken from a variety of captures and retail videos including:

  • General behavior, mobskills, HP, immunities, res ranks, and MDT (here, here see capture logs as chat log cutoff)
  • Elementals refocusing hate on avatar target periodically (here)
  • Elemental En-Plague Power (here)

Steps to test these changes

As a GM go to the BCNM and enter the fight and fight the mobs

@TracentEden2 TracentEden2 changed the title Add Waking the Beast Ifrit BCNM [BCNM] Add Waking the Beast Ifrit BCNM Aug 22, 2024
-- depending on if they are damaged
local spellTarget = nil
if elementalDamaged and avatarDamaged then
if math.random(1, 2) == 1 then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a big fan of ternary expressions, but this is probably a personal preference because I hate if statements ha. Curious what others think though. More for my curiosity than anything (code is perfectly fine).

spellTarget = math.random(1, 2) == 1 and mob or elemental

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a big fan of ternary expressions, but this is probably a personal preference because I hate if statements ha. Curious what others think though. More for my curiosity than anything (code is perfectly fine).

spellTarget = math.random(1, 2) == 1 and mob or elemental

Yeah, I like the if statements mainly for readability, especially for new devs or contributors since this is in Lua.

Copy link
Contributor

@claywar claywar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@TracentEden TracentEden force-pushed the add_waking_the_beast_ifrit_bcnm branch from 27cab68 to 9ded773 Compare August 23, 2024 18:41
Co-Authored-By: dallano <dallano@users.noreply.github.com>
@TracentEden TracentEden force-pushed the add_waking_the_beast_ifrit_bcnm branch from 9ded773 to ee7eb49 Compare August 23, 2024 18:46
@claywar claywar merged commit a105530 into LandSandBoat:base Aug 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants