-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BCNM] Add Waking the Beast Ifrit BCNM #6140
[BCNM] Add Waking the Beast Ifrit BCNM #6140
Conversation
-- depending on if they are damaged | ||
local spellTarget = nil | ||
if elementalDamaged and avatarDamaged then | ||
if math.random(1, 2) == 1 then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a big fan of ternary expressions, but this is probably a personal preference because I hate if statements ha. Curious what others think though. More for my curiosity than anything (code is perfectly fine).
spellTarget = math.random(1, 2) == 1 and mob or elemental
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a big fan of ternary expressions, but this is probably a personal preference because I hate if statements ha. Curious what others think though. More for my curiosity than anything (code is perfectly fine).
spellTarget = math.random(1, 2) == 1 and mob or elemental
Yeah, I like the if statements mainly for readability, especially for new devs or contributors since this is in Lua.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me.
27cab68
to
9ded773
Compare
Co-Authored-By: dallano <dallano@users.noreply.github.com>
9ded773
to
ee7eb49
Compare
I affirm:
What does this pull request do?
This PR adds the waking the beast Ifrit BCNM fight. This is the first in a series of PRs for adding WTB. Note that this does not add the actual quest so players cannot yet enter the BCNM fight, as my plan is to add all of the BCNM fights before a final PR that adds in the quest. Also note that the commented out
-- mob:setMobMod(xi.mobMod.SKIP_ALLEGIANCE_CHECK, 1)
will be enabled once this related PR that adds the specific mob mod is merged.I am not sure if this should be marked as experimental or not?
The info for the PR has been taken from a variety of captures and retail videos including:
Steps to test these changes
As a GM go to the BCNM and enter the fight and fight the mobs