Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CI requirement for LLS #6134

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Enable CI requirement for LLS #6134

merged 1 commit into from
Aug 20, 2024

Conversation

claywar
Copy link
Contributor

@claywar claywar commented Aug 20, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Enables output checking for Lua Language Server in CI

Steps to test these changes

Tested Pass/Fail scenario in CI, expected results achieved

Copy link
Contributor

@Xaver-DaRed Xaver-DaRed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preventive approval

@claywar claywar force-pushed the enable-lls-requirement branch from cb75bc0 to 51d4e80 Compare August 20, 2024 20:12
@claywar claywar merged commit 47a1f60 into base Aug 20, 2024
25 checks passed
@claywar claywar deleted the enable-lls-requirement branch August 20, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants