Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or Ignore remaining Lua Language Server warnings and errors #6133

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

claywar
Copy link
Contributor

@claywar claywar commented Aug 20, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Fixes or adds exceptions for all remaining LLS errors so that CI can be enforced

  • Separated Cruor Prospector tables with different data structures
  • Remove unnecessary bit.bor call with missing parameter
  • Nil check manaclipper nextEvent variable
  • Nil check Lower Jeuno Treasure Coffer 'prize' variable
  • Add LLS exception for __eq and new for missions and hidden quests
  • Nil check dynamis 'te' variable
  • Change default table data type for caskets timeTable
  • Nil check logInfo in setMissionStatus GM Command
  • Define variables on need, remove debug print in avatar code
  • Add TODOs and exceptions for remaining LLS errors and warnings

Steps to test these changes

No impact to gameplay or function should be observed.

* Separated Cruor Prospector tables with different data structures
* Remove unnecessary bit.bor call with missing parameter
* Nil check manaclipper nextEvent variable
* Nil check Lower Jeuno Treasure Coffer 'prize' variable
* Add LLS exception for __eq and new for missions and hidden quests
* Nil check dynamis 'te' variable
* Change default table data type for caskets timeTable
* Nil check logInfo in setMissionStatus GM Command
* Define variables on need, remove debug print in avatar code
* Add TODOs and exceptions for remaining LLS errors and warnings
Copy link
Contributor

@Xaver-DaRed Xaver-DaRed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job

@claywar claywar merged commit 8f0baff into base Aug 20, 2024
13 checks passed
@claywar claywar deleted the lls-errors branch August 20, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants