Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Gobbie Mystery Box dialMask var init value from bool to nil #6131

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

claywar
Copy link
Contributor

@claywar claywar commented Aug 19, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

dialMask needs falsey behavior, but if valid should be int. Change default data type to nil so that lua language server does not complain

Steps to test these changes

No changes should be observed, error should no longer be logged from CI

dialMask needs falsey behavior, but if valid should be int.  Change default data type to nil so that lua language server does not complain
@claywar claywar merged commit 37476a8 into base Aug 19, 2024
13 checks passed
@claywar claywar deleted the dialmask-default-type branch August 19, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants