Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Misc core changes: settings, utils, http server, etc. #4874

Merged
merged 4 commits into from
Dec 17, 2023
Merged

[core] Misc core changes: settings, utils, http server, etc. #4874

merged 4 commits into from
Dec 17, 2023

Conversation

zach2good
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Some misc things I thought of, laid out in their commits

Xaver-DaRed
Xaver-DaRed approved these changes Dec 17, 2023
View reviewed changes
Copy link
Contributor

@Xaver-DaRed Xaver-DaRed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you wanted prepared sql statements

@zach2good
Copy link
Contributor Author

I thought you wanted prepared sql statements

#4601

@zach2good zach2good force-pushed the misc_changes branch 2 times, most recently from 4a5c8f9 to d69e2ce Compare December 17, 2023 14:41
@zach2good zach2good merged commit 480aebe into LandSandBoat:base Dec 17, 2023
12 checks passed
@zach2good zach2good deleted the misc_changes branch December 17, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xaver-DaRed Xaver-DaRed Xaver-DaRed approved these changes

@claywar claywar claywar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zach2good @Xaver-DaRed @claywar