Fix Node 18 Unzip Issues #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just want to point out that as Node 14 LTS is out of support at the end of this month and Node 16 LTS is out of support at the end of September this PR fixes a critical issue that breaks node-tunnel and prevents it from extracting the LT binary zip on Node 18. I found this issue because multiple testcafe lambdatest pipelines failed after upgrading to node 18, which I suspect many customers will be doing as we speak. Probably worth merging this as a priority. |
DanielHaroldLane
force-pushed
the
master
branch
from
b205515 to
a275820
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address the failing unzip package "unzipper" that fails to successfully unzip the LT binary under Node 18. The last package update to "unzipper" was three years ago. Adm-Zip is actively maintained and is functional.
This Addresses #39