Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash from UndoLastRead if nothing previously read #28

Closed
dherbst opened this issue May 2, 2021 · 1 comment
Closed

Crash from UndoLastRead if nothing previously read #28

dherbst opened this issue May 2, 2021 · 1 comment

Comments

@dherbst
Copy link
Contributor

dherbst commented May 2, 2021

Encountered this crash when hitting 'u' if nothing has been read yet:

	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x60 pc=0x44959c1]

goroutine 1 [running]:
github.com/rivo/tview.(*Application).Run.func1(0xc000166380)
	/Users/user/go/pkg/mod/github.com/rivo/tview@v0.0.0-20190829161255-f8bc69b90341/application.go:149 +0x87
panic(0x462c100, 0x4ad9af0)
	/usr/local/go/src/runtime/panic.go:969 +0x1b9
github.com/Lallassu/gorss/internal.(*Controller).Input(0xc0001ef680, 0xc0003183e0, 0xc000166380)
	/Users/user/src/d/gorss/internal/controller.go:595 +0x8e1
github.com/rivo/tview.(*Application).Run(0xc000166380, 0x0, 0x0)
	/Users/user/go/pkg/mod/github.com/rivo/tview@v0.0.0-20190829161255-f8bc69b90341/application.go:219 +0x445
github.com/Lallassu/gorss/internal.(*Window).Start(0xc000248aa0)
	/Users/user/src/d/gorss/internal/window.go:183 +0x85
github.com/Lallassu/gorss/internal.(*Controller).Init(0xc0001ef680, 0xc00014ec80, 0x37, 0x46bd878, 0x14, 0xc00014edc0, 0x35)
	/Users/user/src/d/gorss/internal/controller.go:67 +0x3fc
main.main()
	/Users/user/src/d/gorss/cmd/gorss/main.go:101 +0x778
@Lallassu
Copy link
Owner

Lallassu commented May 3, 2021

Good find, and thanks for adding a fix for this!

@Lallassu Lallassu closed this as completed May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants