fix: change Witness
inheritance to WitnessWrite
for set_stark_proof_with_pis_target
#10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
set_stark_proof_with_pis_target
function is used in thie code of starky-bn254. The out_buffer is type GeneratedValues which only implements WitnessWrite, and not implements Witness.The
Witness
trait not only implementsWitnessWrite
trait for Setter functions, and also implements Getter functions. Butset_stark_proof_with_pis_target
only needs Setters, since this fix could be compiled successfully.