-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: implement cli #25
Conversation
6275377
to
0653a35
Compare
} | ||
|
||
logger.Infof("State proof verification successful for batch %d for chain %d", proofData.BatchHeader.BatchNumber, proofData.BatchHeader.ChainId) | ||
return nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to add the check of committee root recursion, like prevbatch.next_root = curbatch.cur_root
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I will go through sequencer logic and update accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Context
Closes: #24
Reviewers