Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb: Align AudioContext constructors with current specification steps #3203

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tcl3
Copy link
Member

@tcl3 tcl3 commented Jan 9, 2025

This PR updates the spec steps for the AudioContext and OfflineAudioContext constructors.

While working on this I found a few minor inconsistencies, which I believe are (minor) spec issues:

  • The AudioContext spec steps don't mention validating the given sample rate. The /webaudio/the-audio-api/the-audiocontext-interface/audiocontextoptions.html test expects this parameter to be validated.
  • The spec only mentions validating OfflineAudioContext parameters for the constructor that takes individual arguments - not the constructor that takes an OfflineAudioContextOptions object.
  • The AudioContext steps don't include a step to "Determine the [[render quantum size]]". We don't currently implement this, so it's not currently a problem for us.
  • The OfflineAudioContext constructor steps should probably end with a Return c step. This would match the AudioContext constructor steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants