LibWeb: Align AudioContext constructors with current specification steps #3203
+373
−64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the spec steps for the
AudioContext
andOfflineAudioContext
constructors.While working on this I found a few minor inconsistencies, which I believe are (minor) spec issues:
AudioContext
spec steps don't mention validating the given sample rate. The/webaudio/the-audio-api/the-audiocontext-interface/audiocontextoptions.html
test expects this parameter to be validated.OfflineAudioContext
parameters for the constructor that takes individual arguments - not the constructor that takes anOfflineAudioContextOptions
object.AudioContext
steps don't include a step to "Determine the[[render quantum size]]
". We don't currently implement this, so it's not currently a problem for us.OfflineAudioContext
constructor steps should probably end with aReturn c
step. This would match theAudioContext
constructor steps.