Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb: Fix FileAPI constructor #2517

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shlyakpavel
Copy link
Contributor

@shlyakpavel shlyakpavel force-pushed the file_api_constr branch 2 times, most recently from f098435 to 4e60ff1 Compare November 23, 2024 08:20
@shlyakpavel shlyakpavel marked this pull request as ready for review November 23, 2024 08:21
Copy link
Member

@tcl3 tcl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update your commit message to be a bit more descriptive of the change you've made? Something like LibWeb: Update FileAPI File constructor to follow the latest spec steps would work here (if that's within the character limit).

Libraries/LibWeb/FileAPI/File.cpp Outdated Show resolved Hide resolved
Libraries/LibWeb/FileAPI/File.cpp Outdated Show resolved Hide resolved
Libraries/LibWeb/FileAPI/File.cpp Outdated Show resolved Hide resolved
Libraries/LibWeb/FileAPI/File.cpp Outdated Show resolved Hide resolved
@stelar7
Copy link
Contributor

stelar7 commented Nov 23, 2024

Please make sure this doesnt cause any new fails on https://wpt.live/mimesniff/mime-types/parsing.any.html as this code was originally changed to pass tests there😅

@shlyakpavel
Copy link
Contributor Author

@stelar7 should I import that WPT with this PR?

@stelar7
Copy link
Contributor

stelar7 commented Nov 23, 2024

@stelar7 should I import that WPT with this PR?

We dont pass everything there, so im not sure its possible.. but it should atleast still be 1894 / 1898 tests passing

@shlyakpavel
Copy link
Contributor Author

shlyakpavel commented Nov 23, 2024

@stelar7 there are regressions :(

@shlyakpavel shlyakpavel marked this pull request as draft November 23, 2024 19:04
@tcl3
Copy link
Member

tcl3 commented Nov 23, 2024

@Stellar7 Do you know if there's an existing issue for this that we can reference in the code?

@stelar7
Copy link
Contributor

stelar7 commented Nov 23, 2024

@stelar7 Do you know if there's an existing issue for this that we can reference in the code?

This is probably the closest one w3c/FileAPI#43

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

@github-actions github-actions bot added the stale label Dec 15, 2024
@shlyakpavel
Copy link
Contributor Author

This should not be closed yet, as the issue is not resolved, and whenever spec issue is resolved, I update this to both follow the spec and WPTs

@AtkinsSJ AtkinsSJ added blocked and removed stale labels Dec 15, 2024
Copy link

github-actions bot commented Jan 6, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants