-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LibWeb: Fix FileAPI constructor #2517
base: master
Are you sure you want to change the base?
Conversation
f098435
to
4e60ff1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update your commit message to be a bit more descriptive of the change you've made? Something like LibWeb: Update FileAPI File constructor to follow the latest spec steps
would work here (if that's within the character limit).
4e60ff1
to
60d0212
Compare
Please make sure this doesnt cause any new fails on https://wpt.live/mimesniff/mime-types/parsing.any.html as this code was originally changed to pass tests there😅 |
@stelar7 should I import that WPT with this PR? |
We dont pass everything there, so im not sure its possible.. but it should atleast still be 1894 / 1898 tests passing |
@stelar7 there are regressions :( |
@Stellar7 Do you know if there's an existing issue for this that we can reference in the code? |
This is probably the closest one w3c/FileAPI#43 |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
This should not be closed yet, as the issue is not resolved, and whenever spec issue is resolved, I update this to both follow the spec and WPTs |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
60d0212
to
66179f1
Compare
66179f1
to
788fa65
Compare
This fixes http://wpt.live/FileAPI/file/File-constructor.any.html