Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify MSH #6

Merged
merged 1 commit into from
Nov 4, 2020
Merged

simplify MSH #6

merged 1 commit into from
Nov 4, 2020

Conversation

nicolasaunai
Copy link
Contributor

usage :

msh = Magnetosheath(magnetopause="mp_formisano1979", bow_shock="bs_formisano1979")
print(msh.boundaries(0,0))
print(msh.boundaries(0,0, parabolic=True))
print(msh.boundaries(0,0, parabolic=True, confocal=True))

the following leads to an exception :

print(msh.boundaries(0,0, confocal=True))

ValueError: cannot be confocal if not parabolic

@nicolasaunai nicolasaunai added the refactoring refactoring of the code label Nov 4, 2020
BayaneMdW
BayaneMdW approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@BayaneMdW BayaneMdW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me !

@nicolasaunai nicolasaunai merged commit 4344e79 into LaboratoryOfPlasmaPhysics:main Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BayaneMdW BayaneMdW BayaneMdW approved these changes

Assignees
No one assigned
Labels
refactoring refactoring of the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasaunai @BayaneMdW