feat(Project): Adds support for variant languages/optional and turning off learning objectives #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alLearningObjectives array in resulting JSON
…JSON if they're empty
mfdebian
changed the title
…bjectives present in a project
…the variant object
mfdebian
changed the title
mfdebian
changed the title
merunga
previously approved these changes
Apr 9, 2024
lib/__tests__/__fixtures__/01-a-project-with-learning-objectives-turned-off/project.yml
Show resolved
Hide resolved
unjust
reviewed
Apr 26, 2024
lib/__tests__/__fixtures__/01-a-project-with-variant-learning-objectives-duplicated/project.yml
Outdated
Show resolved
Hide resolved
lupomontero
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adolivaresl dejo acá subido lo que revisamos juntxs.
para ejecutarlo, luego de traerte los cambios, hay que hacer
npm linky luego, para probar, estaba ejecutando el siguiente comando:curriculum-parser project ../curriculum/projects/05-fleet-management-api/ --repo Laboratoria/pepita --version 6.6.6.6.6.6 --lo=../curriculum/learning-objectives --variants=python,node > fleet-management-api.jsondonde en el
project.ymldel proyecto05-fleet-management-apinos habíamos traído los cambios de merun, los atributos--repoy--versionson opcionales y puede poner lo que quieras, jijiji y luego todo ese output lo estamos arrojando a un archivo llamadofleet-management-api.jsonpara ir revisando el output