add warning for empty bins in ClusterEnsemble

[m-aguena]

Closes issue #618 , second interaction

[coveralls]

coverage: 100.0%. remained the same
when pulling 7764632 on issue/618/empty_radial_bin_again
into c72eadc on main.

[marina-ricci]

Just to copy here what we discussed : we want to return NaN instead of 0 when there are empty bins.

[m-aguena]

Just to copy here what we discussed : we want to return NaN instead of 0 when there are empty bins.

done!

[combet]

Thank you @m-aguena - I just had a quick look, starting by running the demo_mock_ensemble notebook to check things out.

• I'm not sure I understand the output of cell 15. The legend says there should be dashed lines for "all table" but we only see solid lines in the figure.

• Something else changed and the covariance matrices later do not look like at all what they used to. Cf figures below when running from main and from this branch.

From main:

From this branch:

[combet]

Ah, I see, it's because maximum=nan in that cell (probably because of the new nan values in empty bins?), so the colorscale is not doing what it should...

[m-aguena]

@combet the notebook issue has been fixed, can you re-review it?

[combet]

Thanks @m-aguena - the figure looks good now

May I ask adding a sentence after the figure to comment on the sample covariance having a few empty rows/columns because of empty bins, while this is not a problem for BS and JK methods.

Also, in the output of cell 15, below, is not really explained and we do not see dashed lines in the plot, contrary to what the legend says. I’m actually not sure I understand what this figure aims at showing, so a bit more text would be useful

[combet]

Thank you @m-aguena - I think a bit more comments in the notebooks are needed to help the user understand everything that is shown (see my comments above). Apart from that, everything looks good.

[m-aguena]

Thank you @m-aguena - I think a bit more comments in the notebooks are needed to help the user understand everything that is shown (see my comments above). Apart from that, everything looks good.

done!