Fix the CMB lensing kernel to handle models with non-zero curvature. #1231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitenti
commented
Mar 5, 2025
| @@ -559,7 +559,10 @@ void ccl_get_kappa_kernel(ccl_cosmology *cosmo, double chi_source, | |||
| for (int ichi=0; ichi < nchi; ichi++) { | |||
| double chi = chi_arr[ichi]; | |||
| double a = ccl_scale_factor_of_chi(cosmo, chi, status); | |||
| wchi[ichi] = lens_prefac*(ccl_sinn(cosmo,chi_source-chi,status))*chi/a; | |||
| if (chi != 0.0) | |||
There was a problem hiding this comment.
@damonge This "if" is necessary to avoid 0/0 when chi == 0. If it is safe to assume that the chi_arr only contain 0.0 in its first element this can be simplified.
Pull Request Test Coverage Report for Build 14246188854Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.