Cleanup of conda-incubator & replace deprecated pkg_resources
#1045
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4494008683
💛 - Coveralls |
nikfilippas
changed the title
conda-incubatorconda-incubator & replace deprecated pkg_resources
damonge
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
python-versionargument from the incubator. The Python version is specified inenvironment.yml. There is no need to pass it to the incubator, and in fact this is now trying to access a variable that doesn't exist.It also replaces the deprecated module
pkg_resourceswith the built-inimportlibto assignpyccl.__version__in__init__.py. The deprecated package was throwing warnings in testing.